Re: [PATCH v3 7/8] mikrobus: Add mikrobus driver

From: kernel test robot
Date: Sat Mar 16 2024 - 04:18:56 EST


Hi Ayush,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 61996c073c9b070922ad3a36c981ca6ddbea19a5]

url: https://github.com/intel-lab-lkp/linux/commits/Ayush-Singh/dt-bindings-misc-Add-mikrobus-connector/20240316-025407
base: 61996c073c9b070922ad3a36c981ca6ddbea19a5
patch link: https://lore.kernel.org/r/20240315184908.500352-8-ayushdevel1325%40gmail.com
patch subject: [PATCH v3 7/8] mikrobus: Add mikrobus driver
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240316/202403161617.AYNy6qpP-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240316/202403161617.AYNy6qpP-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403161617.AYNy6qpP-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/misc/mikrobus/mikrobus_manifest.c: In function 'mikrobus_manifest_parse_devices':
>> drivers/misc/mikrobus/mikrobus_manifest.c:422:13: warning: variable 'retval' set but not used [-Wunused-but-set-variable]
422 | int retval, devcount = 0;
| ^~~~~~


vim +/retval +422 drivers/misc/mikrobus/mikrobus_manifest.c

417
418 static int mikrobus_manifest_parse_devices(struct addon_board_info *board)
419 {
420 struct greybus_descriptor_device *desc_device;
421 struct manifest_desc *desc, *next;
> 422 int retval, devcount = 0;
423
424 list_for_each_entry_safe(desc, next, &board->manifest_descs, links) {
425 if (desc->type != GREYBUS_TYPE_DEVICE)
426 continue;
427
428 desc_device = desc->data;
429 retval = mikrobus_manifest_attach_device(board, desc_device);
430 devcount++;
431 }
432
433 return devcount;
434 }
435

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki