[PATCH net] nexthop: fix uninitialized variable in nla_put_nh_group_stats()

From: Dan Carpenter
Date: Sat Mar 16 2024 - 05:46:18 EST


The nh_grp_hw_stats_update() function doesn't always set "hw_stats_used"
so it could be used without being initialized. Set it to false.

Fixes: 5072ae00aea4 ("net: nexthop: Expose nexthop group HW stats to user space")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
net/ipv4/nexthop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
index 74928a9d1aa4..c25bfdf4e25f 100644
--- a/net/ipv4/nexthop.c
+++ b/net/ipv4/nexthop.c
@@ -824,8 +824,8 @@ static int nla_put_nh_group_stats(struct sk_buff *skb, struct nexthop *nh,
u32 op_flags)
{
struct nh_group *nhg = rtnl_dereference(nh->nh_grp);
+ bool hw_stats_used = false;
struct nlattr *nest;
- bool hw_stats_used;
int err;
int i;

--
2.43.0