Re: [PATCH 04/14] mips: dts: ralink: mt7621: reorder sysc node attributes

From: Krzysztof Kozlowski
Date: Sun Mar 17 2024 - 11:09:17 EST


On 16/03/2024 05:54, Justin Swartz wrote:
> Reorder the attributes of the sysc node so that the
> ralink prefixed attribute is placed after those which lack
> prefixes.
>
> Signed-off-by: Justin Swartz <justin.swartz@xxxxxxxxxxxxxxxx>
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 696460b2d..d1d4399d7 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -68,12 +68,15 @@ palmbus: palmbus@1e000000 {
> sysc: syscon@0 {
> compatible = "mediatek,mt7621-sysc", "syscon";
> reg = <0x0 0x100>;
> +
> #clock-cells = <1>;
> #reset-cells = <1>;
> - ralink,memctl = <&memc>;
> +

Why do you move properties one-by-one? This is a lot of churn. Fixup
entire file in one pass.

Best regards,
Krzysztof