Re: [PATCH 01/13] ASoC: dt-bindings: davinci-mcbsp: convert McBSP bindings to yaml schema

[Rob Herring]

On Fri, Mar 15, 2024 at 12:27:33PM +0100, Bastien Curutchet wrote:
> Convert the binding for McBSP controllers for TI SoCs from txt
> to YAML schema.
> 
> Add properties 'clocks', 'clock-names', 'power-domains' and
> '#sound-dai-cells' which were missing from the txt file.
> Add '#sound-dai-cells' and 'clocks' in the example which were missing
> from the txt file.
> 
> Signed-off-by: Bastien Curutchet <bastien.curutchet@xxxxxxxxxxx>
> ---
>  .../bindings/sound/davinci-mcbsp.txt          | 50 ----------
>  .../bindings/sound/davinci-mcbsp.yaml         | 96 +++++++++++++++++++
>  2 files changed, 96 insertions(+), 50 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/davinci-mcbsp.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/davinci-mcbsp.yaml

> diff --git a/Documentation/devicetree/bindings/sound/davinci-mcbsp.yaml b/Documentation/devicetree/bindings/sound/davinci-mcbsp.yaml
> new file mode 100644
> index 000000000000..8b0e9b5da08f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/davinci-mcbsp.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/davinci-mcbsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: McBSP Controller for TI SoCs
> +
> +maintainers:
> +  - Bastien Curutchet <bastien.curutchet@xxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,da850-mcbsp
> +
> +  reg:
> +    minItems: 1
> +    items:
> +      - description: CFG registers
> +      - description: data registers
> +
> +  reg-names:
> +    minItems: 1
> +    items:
> +      - const: mpu
> +      - const: dat
> +
> +  dmas:
> +    items:
> +      - description: transmission DMA channel
> +      - description: reception DMA channel
> +
> +  dma-names:
> +    items:
> +      - const: tx
> +      - const: rx
> +
> +  interrupts:
> +    items:
> +      - description: RX interrupt
> +      - description: TX interrupt
> +
> +  interrupt-names:
> +    items:
> +      - const: rx
> +      - const: tx
> +
> +  clocks:
> +    items:
> +      - description: functional clock
> +
> +  clock-names:
> +    items:
> +      - const: fck
> +
> +  power-domains:
> +    description: phandle to the corresponding power-domain

Drop

> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0
> +
> +required:
> +  - "#sound-dai-cells"
> +  - compatible
> +  - reg
> +  - reg-names
> +  - dmas
> +  - dma-names
> +  - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mcbsp0: mcbsp0@1d10000 {

Drop unused label.


> +      #sound-dai-cells = <0>;
> +      compatible = "ti,da850-mcbsp";
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&mcbsp0_pins>;
> +
> +      reg = <0x111000 0x1000>,
> +            <0x311000 0x1000>;
> +      reg-names = "mpu", "dat";
> +      interrupts = <97>, <98>;
> +      interrupt-names = "rx", "tx";
> +      dmas = <&edma0 3 1
> +              &edma0 2 1>;

<> around each entry.

Otherwise,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> +      dma-names = "tx", "rx";
> +
> +      clocks = <&psc1 14>;
> +    };
> -- 
> 2.43.2
>