Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed

From: Andy Shevchenko
Date: Mon Mar 18 2024 - 06:26:11 EST


On Mon, Mar 18, 2024 at 02:03:12AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] gpiolib: use dev_err when gpiod_configure_flags failed
> > On Fri, Mar 15, 2024 at 3:02 AM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> > wrote:

..

> > It's unclear what the use case is and how this does make life easier.
> > We need to know more!
>
> I forgot to add gpio-ranges in gpio node, then it always fail in my driver
> probe to configure pinctrl. So if using dev_err(), it will be easier for
> me to locate the error point.

At least make sure something like the above is in the commit message of the
next version.

--
With Best Regards,
Andy Shevchenko