RE: [PATCH] ALSA: hda: cs35l41: Support HP Spectre x360 14 eu0000

[Stefan Binding]

Hi,

Support for this laptop was previously added in patch:
33e5e648e631 ("ALSA: hda: cs35l41: Support additional HP Envy Models")

Is your branch out of date?

Thanks,
Stefan Binding

> -----Original Message-----
> From: Anthony I Gilea <i@xxxxxx>
> Sent: Sunday, March 17, 2024 2:05 AM
> To: James Schulman <james.schulman@xxxxxxxxxx>; David Rhodes
> <david.rhodes@xxxxxxxxxx>; Richard Fitzgerald
> <rf@xxxxxxxxxxxxxxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; Takashi
> Iwai <tiwai@xxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx; patches@xxxxxxxxxxxxxxxxxxxxx; linux-
> sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] ALSA: hda: cs35l41: Support HP Spectre x360 14 eu0000
> 
> The new HP Spectre x360 has _DSD for CS35L41 amps in ACPI but
> reset-gpios and spk-id-gpios are merged into single Package of size 4 so
> _DSD parser fails to parse it.
> 
> Overwrite broken _DSD with the correct configuration.
> 
> Signed-off-by: Anthony I Gilea <i@xxxxxx>
> ---
>   sound/pci/hda/cs35l41_hda_property.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --ruNp a/sound/pci/hda/cs35l41_hda_property.c
> b/sound/pci/hda/cs35l41_hda_property.c
> 
> --- a/sound/pci/hda/cs35l41_hda_property.c	2024-03-10
> 23:38:09.000000000 +0300
> +++ b/sound/pci/hda/cs35l41_hda_property.c	2024-03-14
> 18:22:01.887566917 +0300
> @@ -64,6 +64,7 @@ static const struct cs35l41_config cs35l
>   	{ "103C8BE5", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4100, 24 },
>   	{ "103C8BE6", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4100, 24 },
>   	{ "103C8B3A", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4100, 24 },
> +	{ "103C8C15", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4100, 24 },
>   	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 1, 2, 0, 1000, 4500, 24 },
>   	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4500, 24 },
>   	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0
> }, 0, 1, -1, 1000, 4500, 24 },
> @@ -405,6 +406,7 @@ static const struct cs35l41_prop_model c
>   	{ "CSC3551", "103C8BE5", generic_dsd_config },
>   	{ "CSC3551", "103C8BE6", generic_dsd_config },
>   	{ "CSC3551", "103C8B3A", generic_dsd_config },
> +	{ "CSC3551", "103C8C15", generic_dsd_config },
>   	{ "CSC3551", "104312AF", generic_dsd_config },
>   	{ "CSC3551", "10431433", generic_dsd_config },
>   	{ "CSC3551", "10431463", generic_dsd_config },