Re: [PATCH v2] iio: adc: ad7944: Add support for "3-wire mode"

[David Lechner]

On Sun, Mar 17, 2024 at 3:23 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Sun, Mar 17, 2024 at 1:10 AM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> > On Sat, Mar 16, 2024 at 2:57 PM Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> > > Thu, Mar 14, 2024 at 12:43:38PM -0500, David Lechner kirjoitti:
>

..

> > > > +     case AD7944_SPI_MODE_SINGLE:
> > > > +             ret = ad7944_3wire_cs_mode_conversion(adc, &indio_dev->channels[0]);
> > > > +             if (ret)
> > > > +                     goto out;
> > > > +
> > > > +             break;
> > > > +     default:
> > > > +             /* not supported */
> > >
> > > No error code set?
> >
> > This is in an interrupt handler, so I didn't think there was anything
> > we can do with an error.
>
> return IRQ_NONE?
>

Wouldn't this just cause the interrupt handler to trigger again
immediately resulting in very high CPU load? I don't see any other IIO
ADC drivers using the generic triggered buffer returning anything
other than IRQ_HANDLED and I always assumed this was the reason.