Re: [PATCH] x86/tsc: Use topology_max_packages() to get package number

[Dave Hansen]

On 3/17/24 05:00, Zhang, Rui wrote:
>> I also did a big *gulp* when I saw this:
>>
>>         #define topology_max_packages() (__max_logical_packages)
>>
>> and:
>>
>>>         /*
>>>          * Today neither Intel nor AMD support heterogeneous
>>> systems so
>>>          * extrapolate the boot cpu's data to all packages.
>>>          */
>>>         ncpus = cpu_data(0).booted_cores *
>>> topology_max_smt_threads();
>>>         __max_logical_packages = DIV_ROUND_UP(total_cpus, ncpus);
>> Because Intel obviously has heterogeneous systems today.
>>
> Dave, I think you were checking the old code.
> Please refer to commit 090610ba704a ("x86/cpu/topology: Use topology
> bitmaps for sizing"), which is just merged in this merge window.

You're 100% right.  I was looking at a weeks-old tree.  Sorry for the noise.