Re: [PATCH v2] spi: spi-imx: fix off-by-one in mx51 CPU mode burst length
From: Adam Butcher
Date: Mon Mar 18 2024 - 13:25:09 EST
On Mon, March 18, 2024 3:55 pm, Mark Brown wrote:
> On Wed, Mar 13, 2024 at 08:58:19PM +0000, Adam Butcher wrote:
>> From: Adam Butcher <adam@xxxxxxxxxxxxxxx>
>>
>> 992e1211dc91 ("spi: imx: fix the burst length at DMA mode and CPU
>> mode") corrects three cases of setting the ECSPI burst length but
>> erroneously leaves the in-range CPU case one bit to big (in that
>> field a value of 0 means 1 bit). The effect was that transmissions
>> that should have been 8-bit bytes appeared as 9-bit causing failed
>> communication with SPI devices.
>
> This doesn't apply against current code, please check and resend.
>
That refers to the commit my patch fixes. On looking it up I found it
was no longer reachable
(https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?id=992e1211dc91).
The corresponding upstream commit that is reachable from both
torvalds/linux.git/master and broonie/spi.git/spi-next is c712c05e46c8.
Though it was made against 6.8.y, I was able to apply my patch with
git-am to both the latest broonie/spi.git/for-next (593c0afc18d) and
torvalds/linux.git/master (0a7b0acecea2) without conflicts.
Shall I send a v3 correcting the hash mentioned in the commit message?