Re: [PATCH] iio: adc: ad7944: simplify adi,spi-mode property parsing

From: Andy Shevchenko
Date: Mon Mar 18 2024 - 18:44:12 EST


On Mon, Mar 18, 2024 at 11:57 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>
> This simplifies the adi,spi-mode property parsing by using
> device_property_match_property_string() instead of two separate
> functions. Also, the error return value is now more informative
> in cases where there was problem parsing the property.

a problem

..

> + ret = device_property_match_property_string(dev, "adi,spi-mode",
> + ad7944_spi_modes,
> + ARRAY_SIZE(ad7944_spi_modes));
> + if (ret < 0) {
> /* absence of adi,spi-mode property means default mode */
> - adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
> + if (ret == -EINVAL)
> + adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
> + else
> + return dev_err_probe(dev, ret,
> + "getting adi,spi-mode property failed\n");

No need to have 'else'

if (ret != -EINVAL)
return dev_err_probe(dev, ret, "getting
adi,spi-mode property failed\n");

/* absence of adi,spi-mode property means default mode */
adc->spi_mode = AD7944_SPI_MODE_DEFAULT;

> + } else {
> + adc->spi_mode = ret;
> }

--
With Best Regards,
Andy Shevchenko