Re: [linus:master] [nvme] 63dfa10043: fsmark.files_per_sec 6.4% improvement

[Oliver Sang]

hi, Christoph Hellwig,

On Sun, Mar 17, 2024 at 09:36:45PM +0100, Christoph Hellwig wrote:
> On Fri, Mar 15, 2024 at 04:21:13PM +0800, kernel test robot wrote:
> > 
> > 
> > Hello,
> > 
> > kernel test robot noticed a 6.4% improvement of fsmark.files_per_sec on:
> > 
> > 
> > commit: 63dfa1004322d596417f23da43cdc43cf6298c71 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > 
> > testcase: fsmark
> > test machine: 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory
> > parameters:
> 
> That is kinda odd and unexpected.  Is this system using one of the old
> Intel SSDs that this quirk is actually used for?
>

yeah, the nvme sdd on this system is quite old (DC P3608 serial):

https://www.intel.com/content/dam/www/public/us/en/documents/product-specifications/ssd-dc-p3608-spec.pdf