Re: [PATCH v3 0/8] Clean up libperf cpumap's empty function

[Namhyung Kim]

On Mon, Mar 18, 2024 at 2:37 PM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> On Thu, Mar 07, 2024 at 03:47:00PM -0800, Namhyung Kim wrote:
> > Hi Ian,
> >
> > Sorry for the late reply.
> >
> > On Fri, Feb 16, 2024 at 5:04 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Feb 14, 2024 at 2:03 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > > >
> > > > On Fri, Feb 2, 2024 at 3:41 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> > > > >
> > > > > Rename and clean up the use of libperf CPU map functions particularly
> > > > > focussing on perf_cpu_map__empty that may return true for maps
> > > > > containing CPUs but also with an "any CPU"/dummy value.
> > > > >
> > > > > perf_cpu_map__nr is also troubling in that iterating an empty CPU map
> > > > > will yield the "any CPU"/dummy value. Reduce the appearance of some
> > > > > calls to this by using the perf_cpu_map__for_each_cpu macro.
> > > > >
> > > > > v3: Address handling of "any" is arm-spe/cs-etm patch.
> > > > > v2: 6 patches were merged by Arnaldo. New patch added ensure empty
> > > > >     maps are allocated as NULL (suggested by James Clark). Hopefully a
> > > > >     fix to "perf arm-spe/cs-etm: Directly iterate CPU maps".
> > > > >
> > > > > Ian Rogers (8):
> > > > >   libperf cpumap: Add any, empty and min helpers
> > > > >   libperf cpumap: Ensure empty cpumap is NULL from alloc
> > > > >   perf arm-spe/cs-etm: Directly iterate CPU maps
> > > > >   perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty
> > > > >     use
> > > > >   perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty
> > > > >   perf arm64 header: Remove unnecessary CPU map get and put
> > > > >   perf stat: Remove duplicate cpus_map_matched function
> > > > >   perf cpumap: Use perf_cpu_map__for_each_cpu when possible
> > > >
> > > > Ping. Thanks,
> > > > Ian
>
> > > Adrian and James, are you ok with this now?
>
> > I think James is fine now and the Intel-pt part seems straight-forward
> > so I'd like to merge this change.  Please tell me if you have any concerns.
>
> Namhyung,
>
>         I noticed this hasn't been merged and applies cleanly, so I'm
> adding it to perf-tools-next, from your comment above can I take it as
> an Acked-by or even Reviewed-by?

Oh, I thought I did it already, but I probably missed pushing it. :(

Sure you can add it,  I'll do that for the sake of b4.

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung