RE: [PATCH v8 1/8] cpufreq: amd-pstate: Document *_limit_* fields in struct amd_cpudata

From: Yuan, Perry
Date: Tue Mar 19 2024 - 04:03:59 EST


[AMD Official Use Only - General]

Hi Rafael,

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Sent: Monday, March 18, 2024 8:35 PM
> To: Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: rafael.j.wysocki@xxxxxxxxx; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; viresh.kumar@xxxxxxxxxx; Huang, Ray
> <Ray.Huang@xxxxxxx>; Shenoy, Gautham Ranjal
> <gautham.shenoy@xxxxxxx>; Petkov, Borislav <Borislav.Petkov@xxxxxxx>;
> Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Huang, Shimmer
> <Shimmer.Huang@xxxxxxx>; Du, Xiaojian <Xiaojian.Du@xxxxxxx>; Meng,
> Li (Jassmine) <Li.Meng@xxxxxxx>; linux-pm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v8 1/8] cpufreq: amd-pstate: Document *_limit_* fields in
> struct amd_cpudata
>
> On Mon, Mar 18, 2024 at 10:48 AM Perry Yuan <perry.yuan@xxxxxxx>
> wrote:
> >
> > From: "Gautham R. Shenoy" <gautham.shenoy@xxxxxxx>
>
> No changelog.
>
> > Signed-off-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>
>
> Sender sign-off missing (when sending a somebody else's patch, you need to
> add your S-o-b tag to it).


Got it, will fix this and other two patches flags missing in V9.
Thank you for the feedback.

Perry.


>
> > ---
> > include/linux/amd-pstate.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> > index d21838835abd..212f377d615b 100644
> > --- a/include/linux/amd-pstate.h
> > +++ b/include/linux/amd-pstate.h
> > @@ -49,6 +49,10 @@ struct amd_aperf_mperf {
> > * @lowest_perf: the absolute lowest performance level of the processor
> > * @prefcore_ranking: the preferred core ranking, the higher value indicates
> a higher
> > * priority.
> > + * @min_limit_perf: Cached value of the perf corresponding to
> > + policy->min
> > + * @max_limit_perf: Cached value of the perf corresponding to
> > + policy->max
> > + * @min_limit_freq: Cached value of policy->min
> > + * @max_limit_freq: Cached value of policy->max
> > * @max_freq: the frequency that mapped to highest_perf
> > * @min_freq: the frequency that mapped to lowest_perf
> > * @nominal_freq: the frequency that mapped to nominal_perf
> > --
> > 2.34.1
> >
> >