Re: [PATCH v6 1/2] dt-bindings: dma: Add Loongson-1 DMA

From: Keguang Zhang
Date: Tue Mar 19 2024 - 04:29:45 EST


On Mon, Mar 18, 2024 at 2:18 PM Keguang Zhang <keguang.zhang@xxxxxxxxx> wrote:
>
> On Sun, Mar 17, 2024 at 10:40 PM Conor Dooley <conor@xxxxxxxxxx> wrote:
> >
> > On Sat, Mar 16, 2024 at 07:33:53PM +0800, Keguang Zhang via B4 Relay wrote:
> > > From: Keguang Zhang <keguang.zhang@xxxxxxxxx>
> > >
> > > Add devicetree binding document for Loongson-1 DMA.
> > >
> > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx>
> > > ---
> > > V5 -> V6:
> > > Change the compatible to the fallback
> > > Some minor fixes
> > > V4 -> V5:
> > > A newly added patch
> > > ---
> > > .../devicetree/bindings/dma/loongson,ls1x-dma.yaml | 66 ++++++++++++++++++++++
> > > 1 file changed, 66 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml
> > > new file mode 100644
> > > index 000000000000..06358df725c6
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/dma/loongson,ls1x-dma.yaml
> > > @@ -0,0 +1,66 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/dma/loongson,ls1x-dma.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Loongson-1 DMA Controller
> > > +
> > > +maintainers:
> > > + - Keguang Zhang <keguang.zhang@xxxxxxxxx>
> > > +
> > > +description:
> > > + Loongson-1 DMA controller provides 3 independent channels for
> > > + peripherals such as NAND and AC97.
> > > +
> > > +properties:
> > > + compatible:
> > > + oneOf:
> > > + - const: loongson,ls1b-dma
> > > + - items:
> > > + - enum:
> > > + - loongson,ls1c-dma
> > > + - const: loongson,ls1b-dma
> >
> > Aren't there several more devices in this family? Do they not have DMA
> > controllers?
> >
> You are right. Loongson1 is a SoC family.
> However, only 1A/1B/1C have DMA controller.
>
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + interrupts:
> > > + description: Each channel has a dedicated interrupt line.
> > > + minItems: 1
> > > + maxItems: 3
> >
> > Is this number not fixed for each SoC?
> >
> Yes. Actually, it's fixed for the whole family.
>
> > > + interrupt-names:
> > > + minItems: 1
> > > + items:
> > > + - pattern: ch0
> > > + - pattern: ch1
> > > + - pattern: ch2
> >
> > Why have you made these a pattern? There's no regex being used here at
> > all.
> >
> Will change items to the following regex.
> interrupt-names:
> minItems: 1
> items:
> - pattern: "^ch[0-2]$"
>
Sorry. This pattern fails in dt_binding_check.
Will use const instead of pattern.
interrupt-names:
items:
- const: ch0
- const: ch1
- const: ch2


> Thanks!
>
> > Cheers,
> > Cono4.
>
>
>
> --
> Best regards,
>
> Keguang Zhang



--
Best regards,

Keguang Zhang