Re: [PATCH 2/3] arm64: dts: qcom: qdu1000-idp: enable USB nodes

From: Komal Bajaj
Date: Tue Mar 19 2024 - 04:34:57 EST




On 3/12/2024 5:34 AM, Konrad Dybcio wrote:


On 3/11/24 13:14, Dmitry Baryshkov wrote:
On Mon, 11 Mar 2024 at 14:10, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:

Enable both USB controllers and associated hsphy and qmp phy nodes
on QDU1000 IDP.

Co-developed-by: Amrit Anand <quic_amrianan@xxxxxxxxxxx>
Signed-off-by: Amrit Anand <quic_amrianan@xxxxxxxxxxx>
Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 24 ++++++++++++++++++++++++
  1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
index 89b84fb0f70a..126bc71afd90 100644
--- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
@@ -500,3 +500,27 @@ &tlmm {
  &uart7 {
         status = "okay";
  };
+
+&usb_1 {
+       status = "okay";
+};
+
+&usb_1_dwc3 {
+       dr_mode = "peripheral";

Are these ports really peripheral-only?

This was done for testing. Will add the usb-role-switch role.


+       maximum-speed = "high-speed";

More importantly, are these ports really HS-only?

Apologies for this, added it for testing purpose only, forgot to remove it.
Will remove it.

Thanks
Komal


Konrad