[PATCH 1/2] RAS/AMD/FMPM: Avoid NULL ptr deref in get_saved_records()
From: Yazen Ghannam
Date: Tue Mar 19 2024 - 07:35:52 EST
An old, invalid record should be cleared and skipped.
Currently, the record is cleared in ERST, but it is not skipped. This
leads to a NULL pointer dereference when attempting to copy the old
record to the new record.
Continue the loop after clearing an old, invalid record to skip it.
Fixes: 6f15e617cc99 ("RAS: Introduce a FRU memory poison manager")
Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
Tested-by: Muralidhara M K <muralidhara.mk@xxxxxxx>
---
drivers/ras/amd/fmpm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
index 2f4ac9591c8f..9d25195b4538 100644
--- a/drivers/ras/amd/fmpm.c
+++ b/drivers/ras/amd/fmpm.c
@@ -676,8 +676,10 @@ static int get_saved_records(void)
}
new = get_valid_record(old);
- if (!new)
+ if (!new) {
erst_clear(record_id);
+ continue;
+ }
/* Restore the record */
memcpy(new, old, len);
--
2.34.1