Re: [PATCH v4 1/2] x86/cpufeatures: Add dedicated feature word for CPUID leaf 0x80000022[EAX]

From: Ingo Molnar
Date: Tue Mar 19 2024 - 09:00:45 EST



* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> > +/* AMD-defined performance monitoring features, CPUID level 0x80000022 (EAX), word 21 */
> > +#define X86_FEATURE_PERFMON_V2 (21*32+ 0) /* AMD Performance Monitoring Version 2 */
> > +#define X86_FEATURE_AMD_LBR_V2 (21*32+ 1) /* AMD Last Branch Record Extension Version 2 */
>
> Thank you! I presume you tested both patches on the relevant system
> with the X86_FEATURE_AMD_LBR_PMC_FREEZE bug?

Also, Boris reminds me that we really want to do what I suggested
originally and use a new synthethic word here, not a new vendor word, to
keep all the bits better compressed in cpuinfo.x86_capability[] - so one
more iteration will be needed.

Thanks,

Ingo