Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude swap entries

From: Peter Xu
Date: Tue Mar 19 2024 - 10:04:46 EST


On Tue, Mar 19, 2024 at 12:25:39PM +0800, Muchun Song wrote:
> > @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr,
> >
> > int pmd_huge(pmd_t pmd)
> > {
> > - return !pmd_none(pmd) &&
> > - (pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) != _PAGE_VALID;
> > + return pmd_leaf(pmd);;
>
> There is a redundant semicolon in the end.

Will touch it up, thanks. PS: This will be dropped as a whole in patch 12.

--
Peter Xu