Re: [PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

From: Daniel Vetter
Date: Tue Mar 19 2024 - 11:36:29 EST


On Thu, Mar 14, 2024 at 11:20:09AM +0100, Maxime Ripard wrote:
> On Mon, Mar 11, 2024 at 04:58:58PM +0100, Sebastian Wick wrote:
> > When extending support for a driver-specific KMS property to additional
> > drivers, we should apply all the requirements for new properties and
> > make sure the semantics are the same and documented.
> >
> > v2: devs of the driver which introduced property shall help and ack
> >
> > Signed-off-by: Sebastian Wick <sebastian.wick@xxxxxxxxxx>
>
> Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>
>
> We probably want to have Dave or Sima ack on that one too

Yeah that's a good idea and defacto how we handled this - additional users
of anything (whether library or uapi or whatever) get to clean up an
existing mess if it's too bad. But for uapi it's good to be really
explicit and document that.

Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Cheers, Sima
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch