Re: [PATCH v2 0/3] uprobes: two common case speed ups

From: Andrii Nakryiko
Date: Tue Mar 19 2024 - 12:26:23 EST


On Mon, Mar 18, 2024 at 9:21 PM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> Hi,
>
> On Mon, 18 Mar 2024 11:17:25 -0700
> Andrii Nakryiko <andrii@xxxxxxxxxx> wrote:
>
> > This patch set implements two speed ups for uprobe/uretprobe runtime execution
> > path for some common scenarios: BPF-only uprobes (patches #1 and #2) and
> > system-wide (non-PID-specific) uprobes (patch #3). Please see individual
> > patches for details.
>
> This series looks good to me. Let me pick it on probes/for-next.

Great, at least I guessed the Git repo right, if not the branch.
Thanks for pulling it in! I assume some other uprobe-related follow up
patches should be based on probes/for-next as well, right?

>
> Thanks!
>
> >
> > v1->v2:
> > - rebased onto trace/core branch of tracing tree, hopefully I guessed right;
> > - simplified user_cpu_buffer usage further (Oleg Nesterov);
> > - simplified patch #3, just moved speculative check outside of lock (Oleg);
> > - added Reviewed-by from Jiri Olsa.
> >
> > Andrii Nakryiko (3):
> > uprobes: encapsulate preparation of uprobe args buffer
> > uprobes: prepare uprobe args buffer lazily
> > uprobes: add speculative lockless system-wide uprobe filter check
> >
> > kernel/trace/trace_uprobe.c | 103 +++++++++++++++++++++---------------
> > 1 file changed, 59 insertions(+), 44 deletions(-)
> >
> > --
> > 2.43.0
> >
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>