Re: [PATCH] x86, relocs: Ignore relocations in .notes section on walk_relocs

From: Kees Cook
Date: Tue Mar 19 2024 - 12:57:05 EST


On Tue, Mar 19, 2024 at 09:16:40AM +0100, Borislav Petkov wrote:
> On Mon, Mar 18, 2024 at 04:45:45PM -0700, Kees Cook wrote:
> > The commit it refs to landed via -hardening,
>
> Yap, saw that. It should've gone through tip too as it is clearly a tip
> tree patch.
>
> > responsibility of landing this fix too. But it's fine to go via -tip
> > if you prefer?
>
> Yes, please. Just send a Reviewed-by and it'll get picked up.

Okay, thanks!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

>
> Btw, while looking at that second patch, why does it have *three* Fixes:
> tags? I think it wants to fix only your
>
> aaa8736370db ("x86, relocs: Ignore relocations in .notes section")

As I understand it, the first first was incomplete.

--
Kees Cook