Re: [PATCH 09/23] perf annotate-data: Maintain variable type info

From: Arnaldo Carvalho de Melo
Date: Tue Mar 19 2024 - 14:13:18 EST


On Tue, Mar 19, 2024 at 10:44:31AM -0700, Namhyung Kim wrote:
> On Tue, Mar 19, 2024 at 7:07 AM Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > > +void exit_type_state(struct type_state *state)
> > > +{
> > > + struct type_state_stack *stack, *tmp;
> > > +
> > > + list_for_each_entry_safe(stack, tmp, &state->stack_vars, list) {
> > > + list_del(&stack->list);

> > list_del_init()?

> Maybe.. but I'm not sure how much value it'd have as we free it right after.

Usually the value is in catching use after free more quickly, i.e.
someone may have a pointer to a freed list and then it would be able to
traverse the list of freed elements.

- Arnaldo