Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch

From: Daniel Golle
Date: Tue Mar 19 2024 - 14:26:25 EST


On Mon, Mar 18, 2024 at 10:46:22AM +0300, Arınç ÜNAL via B4 Relay wrote:
> Hi.
>
> This patch series fixes EEE support for MT7531 and the switch on the MT7988
> SoC. EEE did not work on MT7531 on most boards before this, it is unclear
> what's the status on MT7988 SoC switch as I don't have the hardware.

EEE seems to already work just fine on the MT7988 built-in switch, at least
on the BPI-R4. I don't think the SoC has bootstrap pins related to EEE like
stand-alone MT753x may have.

root@bpi-r4:~# ethtool --show-eee lan1
EEE settings for lan1:
EEE status: disabled
Tx LPI: 30 (us)
Supported EEE link modes: 100baseT/Full
1000baseT/Full
Advertised EEE link modes: Not reported
Link partner advertised EEE link modes: 100baseT/Full
1000baseT/Full

root@bpi-r4:~# ethtool --set-eee lan1 eee on
root@bpi-r4:~# ethtool --show-eee lan1
EEE settings for lan1:
EEE status: enabled - inactive
Tx LPI: 30 (us)
Supported EEE link modes: 100baseT/Full
1000baseT/Full
Advertised EEE link modes: 100baseT/Full
1000baseT/Full
Link partner advertised EEE link modes: Not reported
root@bpi-r4:~# ethtool --show-eee lan1
EEE settings for lan1:
EEE status: enabled - active
Tx LPI: 30 (us)
Supported EEE link modes: 100baseT/Full
1000baseT/Full
Advertised EEE link modes: 100baseT/Full
1000baseT/Full
Link partner advertised EEE link modes: 100baseT/Full
1000baseT/Full

So don't fix if it ain't broken maybe...?

>
> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> ---
> Arınç ÜNAL (3):
> net: dsa: mt7530: fix enabling EEE on MT7531 switch on all boards
> net: dsa: mt7530: fix disabling EEE on failure on MT7531 and MT7988
> net: phy: mediatek-ge: do not disable EEE advertisement
>
> drivers/net/dsa/mt7530.c | 7 +++++++
> drivers/net/dsa/mt7530.h | 7 ++++++-
> drivers/net/phy/mediatek-ge.c | 3 ---
> 3 files changed, 13 insertions(+), 4 deletions(-)
> ---
> base-commit: ea80e3ed09ab2c2b75724faf5484721753e92c31
> change-id: 20240317-for-net-mt7530-fix-eee-for-mt7531-mt7988-a5c5453cc0e8
>
> Best regards,
> --
> Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
>
>