Re: [PATCH v9 1/1] mm: report per-page metadata information

[Andrew Morton]

On Tue, 20 Feb 2024 13:45:58 -0800 Sourav Panda <souravpanda@xxxxxxxxxx> wrote:

> Adds two new per-node fields, namely nr_memmap and nr_memmap_boot,
> to /sys/devices/system/node/nodeN/vmstat and a global Memmap field
> to /proc/meminfo. This information can be used by users to see how
> much memory is being used by per-page metadata, which can vary
> depending on build configuration, machine architecture, and system
> use.

I yield to no man in my admiration of changelogging but boy, that's a
lot of changelogging.  Would it be possible to consolidate the [0/N]
coverletter and the [1/N] changelog into a single thing please?

>  Documentation/filesystems/proc.rst |  3 +++
>  fs/proc/meminfo.c                  |  4 ++++
>  include/linux/mmzone.h             |  4 ++++
>  include/linux/vmstat.h             |  4 ++++
>  mm/hugetlb_vmemmap.c               | 17 ++++++++++++----
>  mm/mm_init.c                       |  3 +++
>  mm/page_alloc.c                    |  1 +
>  mm/page_ext.c                      | 32 +++++++++++++++++++++---------
>  mm/sparse-vmemmap.c                |  8 ++++++++
>  mm/sparse.c                        |  7 ++++++-
>  mm/vmstat.c                        | 26 +++++++++++++++++++++++-
>  11 files changed, 94 insertions(+), 15 deletions(-)

And yet we offer the users basically no documentation.  The new sysfs
file should be documented under Documentation/ABI somewhere and
perhaps we could prepare some more expansive user-facing documentation
elsewhere?

I'd like to hear others' views on the overall usefulness/utility of this
change, please?