Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Document missing s32g3 board

[Krzysztof Kozlowski]

On 19/03/2024 23:16, Wadim Mueller wrote:
> The nxp, s32g399a-rdb3 board is not documented.

Use full name of the board.

Subject: How is it missing? There is no such board in the kernel, so
binding is not missing. Also, you touch here serial...

> 
>  * Add entry for S32G3 based boards with nxp,s32g399a-rdb3 item
>  * Add nxp,s32g3-linflexuart documentation
> 
> Signed-off-by: Wadim Mueller <wafgo01@xxxxxxxxx>

Bindings go before users.

> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml              | 6 ++++++
>  .../devicetree/bindings/serial/fsl,s32-linflexuart.yaml     | 3 +++

Split the patches. They will go via different subsystems.

>  2 files changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 228dcc5c7d6f..23bf1d7f95b1 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1503,6 +1503,12 @@ properties:
>                - nxp,s32g274a-rdb2
>            - const: nxp,s32g2
>  
> +      - description: S32G3 based Boards
> +        items:
> +          - enum:
> +              - nxp,s32g399a-rdb3
> +          - const: nxp,s32g3


Best regards,
Krzysztof