Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off

From: Andy Shevchenko
Date: Wed Mar 20 2024 - 12:36:25 EST


On Wed, Mar 20, 2024 at 06:32:10PM +0200, Andy Shevchenko wrote:
> When iDMA 64-bit device is powered off, the IRQ status register
> is all 1:s. This is never happen in real case and signalling that
> the device is simply powered off. Don't try to serve interrupts
> that are not ours.

..

> dev_vdbg(idma64->dma.dev, "%s: status=%#x\n", __func__, status);

Dunno if I actually also need to move this message to after the checks...

> + /* Since IRQ may be shared, check if DMA controller is powered on */
> + if (status == GENMASK(31, 0))
> + return IRQ_NONE;
> +
> /* Check if we have any interrupt from the DMA controller */
> if (!status)
> return IRQ_NONE;

--
With Best Regards,
Andy Shevchenko