Re: [PATCH] acpi: EINJ: mark remove callback as non-__exit

[Rafael J. Wysocki]

On Wed, Mar 20, 2024 at 8:58 PM Dan Williams <dan.j.williams@xxxxxxxxx> wrote:
>
> Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > The remove callback of a device is called whenever it is unbound,
> > which may happen during runtime e.g. through sysfs, so this is not
> > allowed to be dropped from the binary:
> >
> > WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
> > ERROR: modpost: Section mismatches detected.
> >
> > Remove that annotation.
>
> Looks good, not sure why the build robots missed this while this was
> sitting in -next. Yes, this was a side effect of reusing the former
> einj_exit() as the device remove callback.
>
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
>
> Rafael, can you pick this up?

I will, thanks!