Re: [PATCH v3 6/6] iio: pressure: Add triggered buffer support for BMP280 driver

From: Andy Shevchenko
Date: Wed Mar 20 2024 - 17:26:03 EST


On Wed, Mar 20, 2024 at 06:46:02PM +0100, Vasileios Amoiridis wrote:
> On Wed, Mar 20, 2024 at 01:16:03PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 19, 2024 at 01:29:25AM +0100, Vasileios Amoiridis wrote:

..

> > > /*
> > > - * Maximum number of consecutive bytes read for a temperature or
> > > - * pressure measurement is 3.
> > > + * Maximum number of a burst read for temperature, pressure, humidity
> > > + * is 8 bytes.
> > > */
> > > - if (val_size > 3)
> > > + if (val_size > 8)
> >
> > sizeof() / new definition for the buf[] size?
>
> In a previous commit that I was fixing this SPI driver, Jonathan had mentioned
> that there is no need for a specific definition since it will only be used
> here so that's why I kept it as is.

It seems not only here, but also in the buf[] definition in the struct.

--
With Best Regards,
Andy Shevchenko