RE: [PATCH v6 1/6] cpufreq: acpi: move MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h

[Yuan, Perry]

[AMD Official Use Only - General]

Hi Rafael,

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Sent: Monday, March 18, 2024 8:43 PM
> To: Yuan, Perry <Perry.Yuan@xxxxxxx>
> Cc: rafael.j.wysocki@xxxxxxxxx; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx>; viresh.kumar@xxxxxxxxxx; Huang, Ray
> <Ray.Huang@xxxxxxx>; Shenoy, Gautham Ranjal
> <gautham.shenoy@xxxxxxx>; Petkov, Borislav <Borislav.Petkov@xxxxxxx>;
> Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Huang, Shimmer
> <Shimmer.Huang@xxxxxxx>; oleksandr@xxxxxxxxxxxxxx; Du, Xiaojian
> <Xiaojian.Du@xxxxxxx>; Meng, Li (Jassmine) <Li.Meng@xxxxxxx>; linux-
> pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v6 1/6] cpufreq: acpi: move
> MSR_K7_HWCR_CPB_DIS_BIT into msr-index.h
>
> On Mon, Mar 18, 2024 at 11:12 AM Perry Yuan <perry.yuan@xxxxxxx>
> wrote:
> >
> > There are some other drivers also need to use the
> > MSR_K7_HWCR_CPB_DIS_BIT for CPB control bit, so it makes sense to move
> > the definition to a common header file to allow other driver to use it.
> >
> > No intentional functional impact.
> >
> > Suggested-by: Gautham Ranjal Shenoy <gautham.shenoy@xxxxxxx>
> > Signed-off-by: Perry Yuan <perry.yuan@xxxxxxx>
>
> This change is fine with me, so
>
> Acked-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>

Thank you help to ack the change,
Will pick tag in next version.

Perry.

>
> > ---
> >  arch/x86/include/asm/msr-index.h | 2 ++
> >  drivers/cpufreq/acpi-cpufreq.c   | 2 --
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/msr-index.h
> > b/arch/x86/include/asm/msr-index.h
> > index 05956bd8bacf..41503647192e 100644
> > --- a/arch/x86/include/asm/msr-index.h
> > +++ b/arch/x86/include/asm/msr-index.h
> > @@ -775,6 +775,8 @@
> >  #define MSR_K7_HWCR_IRPERF_EN
> BIT_ULL(MSR_K7_HWCR_IRPERF_EN_BIT)
> >  #define MSR_K7_FID_VID_CTL             0xc0010041
> >  #define MSR_K7_FID_VID_STATUS          0xc0010042
> > +#define MSR_K7_HWCR_CPB_DIS_BIT                25
> > +#define MSR_K7_HWCR_CPB_DIS
> BIT_ULL(MSR_K7_HWCR_CPB_DIS_BIT)
> >
> >  /* K6 MSRs */
> >  #define MSR_K6_WHCR                    0xc0000082
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c
> > b/drivers/cpufreq/acpi-cpufreq.c index 37f1cdf46d29..2fc82831bddd
> > 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -50,8 +50,6 @@ enum {
> >  #define AMD_MSR_RANGE          (0x7)
> >  #define HYGON_MSR_RANGE                (0x7)
> >
> > -#define MSR_K7_HWCR_CPB_DIS    (1ULL << 25)
> > -
> >  struct acpi_cpufreq_data {
> >         unsigned int resume;
> >         unsigned int cpu_feature;
> > --
> > 2.34.1
> >
> >