Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO reset controller
From: Krzysztof Kozlowski
Date: Thu Mar 21 2024 - 03:18:48 EST
On 20/03/2024 20:59, Mark Brown wrote:
> The GPIO reset controller uses gpiolib but there is no Kconfig
> dependency reflecting this fact, add one.
>
> With the addition of the controller to the arm64 defconfig this is
> causing build breaks for arm64 virtconfig in -next:
>
> aarch64-linux-gnu-ld: drivers/reset/core.o: in function `__reset_add_reset_gpio_lookup':
> /build/stage/linux/drivers/reset/core.c:861:(.text+0xccc): undefined reference to `gpio_device_find_by_fwnode'
>
Lack of dependency was intentional: because there is no dependency.
GPIOLIB is optional. Because of that I added few stubs for missing
GPIOLIB functions, but I missed this stub here.
I propose to add gpio_device_find_by_fwnode() stub for !GPIOLIB case,
instead of adding dependency.
Best regards,
Krzysztof