Re: [RFC PATCH net-next v4 04/11] net/smc: implement some unsupported operations of loopback-ism

[Jan Karcher]

On 17/03/2024 11:05, Wen Gu wrote:
> vlan operations are not supported currently since the need for vlan in
> loopback-ism situation does not seem to be strong.
>
> signal_event operation is not supported since no event now needs to be
> processed by loopback-ism device.

Hi Wen Gu,

Could we re-phrase this commit message please? I had some trouble 
reading it. Maybe something along:

Operations that loopback-ism does not support currently:
- vlan operations, since there is no strong use-case for it
- signal_event operations, since there are no events to be processed
    by the loopback-ism device.

Thanks
- Jan

> Signed-off-by: Wen Gu <guwen@xxxxxxxxxxxxxxxxx>
> ---
>   net/smc/smc_loopback.c | 36 +++++++++++++++++++++++++++++++-----
>   1 file changed, 31 insertions(+), 5 deletions(-)
>
> diff --git a/net/smc/smc_loopback.c b/net/smc/smc_loopback.c
> index 7656a2474500..253128c77208 100644
> --- a/net/smc/smc_loopback.c
> +++ b/net/smc/smc_loopback.c
> @@ -49,6 +49,32 @@ static int smc_lo_query_rgid(struct smcd_dev *smcd, struct smcd_gid *rgid,
>   	return 0;
>   }
>   
> +static int smc_lo_add_vlan_id(struct smcd_dev *smcd, u64 vlan_id)
> +{
> +	return -EOPNOTSUPP;
> +}
> +
> +static int smc_lo_del_vlan_id(struct smcd_dev *smcd, u64 vlan_id)
> +{
> +	return -EOPNOTSUPP;
> +}
> +
> +static int smc_lo_set_vlan_required(struct smcd_dev *smcd)
> +{
> +	return -EOPNOTSUPP;
> +}
> +
> +static int smc_lo_reset_vlan_required(struct smcd_dev *smcd)
> +{
> +	return -EOPNOTSUPP;
> +}
> +
> +static int smc_lo_signal_event(struct smcd_dev *dev, struct smcd_gid *rgid,
> +			       u32 trigger_irq, u32 event_code, u64 info)
> +{
> +	return 0;
> +}
> +
>   static int smc_lo_supports_v2(void)
>   {
>   	return SMC_LO_V2_CAPABLE;
> @@ -77,11 +103,11 @@ static const struct smcd_ops lo_ops = {
>   	.query_remote_gid = smc_lo_query_rgid,
>   	.register_dmb		= NULL,
>   	.unregister_dmb		= NULL,
> -	.add_vlan_id		= NULL,
> -	.del_vlan_id		= NULL,
> -	.set_vlan_required	= NULL,
> -	.reset_vlan_required	= NULL,
> -	.signal_event		= NULL,
> +	.add_vlan_id = smc_lo_add_vlan_id,
> +	.del_vlan_id = smc_lo_del_vlan_id,
> +	.set_vlan_required = smc_lo_set_vlan_required,
> +	.reset_vlan_required = smc_lo_reset_vlan_required,
> +	.signal_event = smc_lo_signal_event,
>   	.move_data		= NULL,
>   	.supports_v2 = smc_lo_supports_v2,
>   	.get_local_gid = smc_lo_get_local_gid,