Re: [PATCH v1] thermal: devfreq_cooling: Fix perf state when calculate dfc res_util

[Lukasz Luba]

On 3/21/24 08:37, 张烨 wrote:
> Hi Lukasz,
>
> Regarding your question about how I triggered the issue andifI have a 
> driver that provides the get_real_power() callback:
>
> I encountered thisissue whilecalculating the GPU power consumption onthe 
> Rockchip RK3399 platform. The GPU model isMali T860, which isan ARM 
> Midgard GPU. The driver version isr18p0-01rel0, andit provides the 
> get_real_power() callback.Best regards, Ye Zhang

Yes that would trigger the issue. Thank you Ye for
sharing that.

BTW, I also use RK3399 for my mainline kernel development.
I use the Rock Pi 4SE with the mainline GPU driver
'panfrost'. That GPU driver doesn't support the get_real_power()
callback, but maybe it would be worth to add it...

Please send the v2 and I will add my reviewed-by tag for it.

Regards,
Lukasz