Re: [PATCH 2/2] dt-bindings: dma: Convert ingenic-pdma doc to YAML
From: Rob Herring
Date: Thu Mar 21 2024 - 05:23:58 EST
On Thu, 21 Mar 2024 16:02:28 +0800, bin.yao@xxxxxxxxxxx wrote:
> From: "bin.yao" <bin.yao@xxxxxxxxxxx>
>
> Convert the textual documentation for the Ingenic SoCs PDMA Controller
> devicetree binding to YAML.
>
> Signed-off-by: bin.yao <bin.yao@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/dma/ingenic,pdma.yaml | 67 +++++++++++++++++++
> include/dt-bindings/dma/ingenic-pdma.h | 45 +++++++++++++
> 2 files changed, 112 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/ingenic,pdma.yaml
> create mode 100644 include/dt-bindings/dma/ingenic-pdma.h
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/ingenic,pdma.example.dtb: dma@13420000: $nodename:0: 'dma@13420000' does not match '^dma-controller(@.*)?$'
from schema $id: http://devicetree.org/schemas/dma/ingenic,pdma.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/ingenic,pdma.example.dtb: dma@13420000: 'interrupts-names' is a required property
from schema $id: http://devicetree.org/schemas/dma/ingenic,pdma.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/ingenic,pdma.example.dtb: dma@13420000: Unevaluated properties are not allowed ('interrupt-names' was unexpected)
from schema $id: http://devicetree.org/schemas/dma/ingenic,pdma.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240321080228.24147-2-bin.yao@xxxxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.