回复: [v1] staging: media: starfive: Renamed capture_raw to capture_dump

From: Changhuang Liang
Date: Thu Mar 21 2024 - 08:17:49 EST


Hi, Hans

Thanks for your comments.

> On 01/03/2024 8:00 am, Changhuang Liang wrote:
> > The pixel formats captured by the capture_raw video device depends on
> > what pixel formats come from the source device. It is actually dump
> > the source device data. So renamed it to capture_dump.
>
> I don't think 'dump' is a great name. I think what you really want to say is
> 'unprocessed'. And usually that is indeed called 'raw capture'.
>

StarFive JH7110 SoC also supports the output of the raw format data from ISP port, see:

https://lore.kernel.org/all/20240306093334.9321-1-changhuang.liang@xxxxxxxxxxxxxxxx/

So I think it is better to call the ISP output port "capture_raw".

On the other hand, Old "capture_raw" video devices can also support YUV color space,
mainly depending on the camera output format. There may be a confusion called it "capture_raw".

Regards,
Changhuang