Re: [PATCH v9 1/2] dt-bindings: mtd: fixed-partitions: Add alignment properties
From: Rob Herring
Date: Thu Mar 21 2024 - 09:39:15 EST
On Wed, Mar 20, 2024 at 06:24:48PM +1300, Simon Glass wrote:
> Add three properties for controlling alignment of partitions, aka
> 'entries' in fixed-partition.
>
> For now there is no explicit mention of hierarchy, so a 'section' is
> just the 'fixed-partitions' node.
>
> These new properties are inputs to the Binman packaging process, but are
> also needed if the firmware is repacked, to ensure that alignment
> constraints are not violated. Therefore they are provided as part of
> the schema.
>
> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx>
> ---
>
> Changes in v9:
> - Move binding example to next batch to avoid build error
>
> Changes in v7:
> - Drop patch 'Add binman compatible'
> - Put the alignment properties into the fixed-partition binding
>
> Changes in v6:
> - Correct schema-validation errors missed due to older dt-schema
> (enum fix and reg addition)
>
> Changes in v5:
> - Add value ranges
> - Consistently mention alignment must be power-of-2
> - Mention that alignment refers to bytes
>
> Changes in v2:
> - Fix 'a' typo in commit message
>
> .../bindings/mtd/partitions/partition.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> index 1ebe9e2347ea..39c7d7672783 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> @@ -57,6 +57,57 @@ properties:
> user space from
> type: boolean
>
> + align:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 1
Shouldn't this and the others be 2?
Otherwise,
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>