Re: [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network

[Rob Herring]

On Wed, Mar 20, 2024 at 09:43:16PM +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_MOBILE for LEDs that indicate status of mobile network
> connection.
> As an example, "Mobile" LEDs on IIJ SA-W2 indicate status (no signal,
> too low, low, good) of mobile network connection via dongle connected
> to USB port.
> 
> Suggested-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@xxxxxxxxx>
> ---
>  include/dt-bindings/leds/common.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index ecea167930d9..d4b8498bde7f 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -91,6 +91,7 @@
>  #define LED_FUNCTION_LAN "lan"
>  #define LED_FUNCTION_MAIL "mail"
>  #define LED_FUNCTION_MTD "mtd"
> +#define LED_FUNCTION_MOBILE "mobile"

Why doesn't "wan" work?

>  #define LED_FUNCTION_PANIC "panic"
>  #define LED_FUNCTION_PROGRAMMING "programming"
>  #define LED_FUNCTION_RX "rx"
> -- 
> 2.25.1
>