Re: [PATCH net v2 0/2] MT7530 DSA subdriver fix VLAN egress and handling of all link-local frames

From: Jakub Kicinski
Date: Thu Mar 21 2024 - 10:42:59 EST


On Thu, 21 Mar 2024 09:19:02 -0400 Konstantin Ryabitsev wrote:
> On Thu, Mar 21, 2024 at 02:29:19PM +0300, Arınç ÜNAL wrote:
> > > For future memory: I think the SoB in the cover letter is not required,
> > > and is, at least to me, a bit confusing.
> > >
> > > No action needed here, I'll keep this unmodified, but I suggest to omit
> > > it in future submission.
> >
> > b4 puts it on the cover letter so it's not my doing.
>
> This is done because many subsystems use the cover letter as the merge commit
> message.

Could be wrong, but I think it was DaveM who originated this practice,
in networking..

> Those subsystems who don't follow this practice don't generally care
> if there's a Signed-Off-By in the cover letter anyway, so I don't see why this
> is a concern that it's there.

Because we have to remove it, extra work. And the benefit of adding it
in the first place is unclear.