Re: [RESEND PATCH v2 8/9] fs: inotify: delete these unnecessary static variables it_zero and it_int_max

From: Wen Yang
Date: Thu Mar 21 2024 - 10:46:51 EST




On 2024/3/21 19:38, Jan Kara wrote:
On Thu 21-03-24 11:55:55, Joel Granados wrote:
On Wed, Mar 20, 2024 at 11:36:03AM +0100, Jan Kara wrote:
On Tue 19-03-24 23:57:49, wenyang.linux@xxxxxxxxxxx wrote:
From: Wen Yang <wenyang.linux@xxxxxxxxxxx>

Delete unnecessary static variables (it_zero and it_int_max)
and encode them directly in the table entry.

Signed-off-by: Wen Yang <wenyang.linux@xxxxxxxxxxx>
Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Joel Granados <j.granados@xxxxxxxxxxx>
Cc: Christian Brauner <brauner@xxxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Cc: "Darrick J. Wong" <djwong@xxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx

This looks as a sensible cleanup but I don't see the first patch in the
series (and neither it is archived at lore.kernel.org) so I cannot really
verify whether your conversion is correct...
This was my original comment. If you want to see the cover letter
look for this mail ID tencent_06797E65CFC655DCD4F0414B9380E95ECC08@xxxxxx

Not sure why it separates the cover letter from the rest of the patches.

No, that is actually a different email :) Based on lore the message ID
should be:
26c450f6467b4cbaf94cdb10f047abc6ab0c2a5d.1710863674.git.wenyang.linux@xxxxxxxxxxx

but the email is not in the archive...

Honza

Sorry, my email box changed the message ID when sending, but it can be found in lcore:


or
https://lore.kernel.org/all/tencent_0D6ABA209A4980742DE6003FBFE7FE2A3207@xxxxxx/


If it causes any inconvenience to you, I can resend it. After some experiments, I have finally found a way to send them in a thread.

--
Best wishes,
Wen