Re: [PATCH v2 2/3] wifi: b43: Convert sprintf/snprintf to sysfs_emit
From: Kalle Valo
Date: Thu Mar 21 2024 - 11:08:18 EST
Li Zhijian <lizhijian@xxxxxxxxxxx> wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
> sprintf() will be converted as weel if they have.
>
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> CC: Kalle Valo <kvalo@xxxxxxxxxx>
> CC: linux-wireless@xxxxxxxxxxxxxxx
> CC: b43-dev@xxxxxxxxxxxxxxxxxxx
> Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx>
2 patches applied to wireless-next.git, thanks.
6db5c15c8b6a wifi: b43: Convert sprintf/snprintf to sysfs_emit
48be5774b21b wifi: ti: Convert sprintf/snprintf to sysfs_emit
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-2-lizhijian@xxxxxxxxxxx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches