Re: [PATCH V2] gpiolib: use dev_err() when gpiod_configure_flags failed

[Bartosz Golaszewski]

On Thu, Mar 21, 2024 at 6:40 AM Peng Fan <peng.fan@xxxxxxx> wrote:
> > > >
> > > > I'm not convinced, so not my call to approve / reject, but see a remark
> > below.
> > >
> > > You mean dev_err not help or else?
> >
> > Moving it to error level.
> > Usually developers enable CONFIG_DEBUG_GPIO for these messages to
> > appear.
>
> But this is a error log. Let's leave this to gpio maintainers.
>

I'm fine with this change.

> >
> > ...
> >
> > > > >         ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
> > > > >         if (ret < 0) {
> > > > > -               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
> > > > > +               dev_err(consumer, "setup of GPIO %s failed: %d\n",
> > > > > + con_id, ret);
> > > > >                 gpiod_put(desc);
> > > > >                 return ERR_PTR(ret);
> > > >
> > > > While at it, can you move it to be after the gpiod_put()?
> > >
> > > Does it matter?
> >
> > Yes, the system gives resource back as soon as possible.
>
> Got it.
>

Please change this and resend it.

Bart