Re: [RESEND PATCH v2 8/9] fs: inotify: delete these unnecessary static variables it_zero and it_int_max

From: Joel Granados
Date: Thu Mar 21 2024 - 12:42:40 EST


On Thu, Mar 21, 2024 at 12:38:49PM +0100, Jan Kara wrote:
> On Thu 21-03-24 11:55:55, Joel Granados wrote:
> > On Wed, Mar 20, 2024 at 11:36:03AM +0100, Jan Kara wrote:
> > > On Tue 19-03-24 23:57:49, wenyang.linux@xxxxxxxxxxx wrote:
> > > > From: Wen Yang <wenyang.linux@xxxxxxxxxxx>
> > > >
> > > > Delete unnecessary static variables (it_zero and it_int_max)
> > > > and encode them directly in the table entry.
> > > >
> > > > Signed-off-by: Wen Yang <wenyang.linux@xxxxxxxxxxx>
> > > > Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> > > > Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> > > > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> > > > Cc: Joel Granados <j.granados@xxxxxxxxxxx>
> > > > Cc: Christian Brauner <brauner@xxxxxxxxxx>
> > > > Cc: Jan Kara <jack@xxxxxxx>
> > > > Cc: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> > > > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > >
> > > This looks as a sensible cleanup but I don't see the first patch in the
> > > series (and neither it is archived at lore.kernel.org) so I cannot really
> > > verify whether your conversion is correct...
> > This was my original comment. If you want to see the cover letter
> > look for this mail ID tencent_06797E65CFC655DCD4F0414B9380E95ECC08@xxxxxx
> >
> > Not sure why it separates the cover letter from the rest of the patches.
>
> No, that is actually a different email :) Based on lore the message ID
Indeed. I have no idea where I got that ID from. I went back and found
the one I wanted: https://lore.kernel.org/all/tencent_C5E6023F97E7CC2A046AAEA09BC9ACF43907@xxxxxx/
that one is the original V2. This one is just a resend AFAIK.

> should be:
> 26c450f6467b4cbaf94cdb10f047abc6ab0c2a5d.1710863674.git.wenyang.linux@xxxxxxxxxxx
>
> but the email is not in the archive...
>
> Honza
> --
> Jan Kara <jack@xxxxxxxx>
> SUSE Labs, CR

--

Joel Granados

Attachment: signature.asc
Description: PGP signature