Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

[Mark Brown]

On Thu, Mar 21, 2024 at 06:08:16PM +0100, Karel Balej wrote:
> Mark Brown, 2024-03-21T16:58:44+00:00:

> > > > > > > +static const struct regmap_config pm886_i2c_regmap = {
> > > > > > > +	.reg_bits = 8,
> > > > > > > +	.val_bits = 8,
> > > > > > > +	.max_register = PM886_REGMAP_CONF_MAX_REG,
> > > > > > > +};

..

> > You shouldn't be creating two regmaps for the same set of registers,
> > that just opens the potential for confusion.

> Just the regmap config is the same. Otherwise, each regmap lives at a
> different I2C address.

Do they both genuinely have the same maximum register?

Attachment: signature.asc
Description: PGP signature