Re: [PATCH 00/31] Clean up thermal zone polling-delay

[Daniel Lezcano]

On 19/03/2024 17:13, Konrad Dybcio wrote:
> A trivial follow-up on the changes introduced in Commit 488164006a28
> ("thermal/of: Assume polling-delay(-passive) 0 when absent").
>
> Should probably wait until v6.9-rc1 so that the patch in question is
> in the base tree, otherwise TZs will fail to register.
>
> FWIW, Compile-tested only (except 8280).
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---

Are you sure these changes are correct. They are not related to commit 
488164006a28.

If the sensor has interrupt support, then it can specify:

	polling-delay = <0>;

As a zero polling value can be omitted in the DT then it can be removed.


Then when a trip point is crossed, the interrupt fires but then it must 
sample the temperature of the thermal zone to do the mitigation.

I doubt polling-delay-passive must be removed. The changes you 
introduced just disable the mitigation and that will lead to board wild 
reboots.

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog