Re: [PATCH v2 net] nexthop: fix uninitialized variable in nla_put_nh_group_stats()

From: Ido Schimmel
Date: Thu Mar 21 2024 - 13:36:23 EST


On Thu, Mar 21, 2024 at 05:42:18PM +0300, Dan Carpenter wrote:
> The "*hw_stats_used" value needs to be set on the success paths to prevent
> an uninitialized variable bug in the caller, nla_put_nh_group_stats().
>
> Fixes: 5072ae00aea4 ("net: nexthop: Expose nexthop group HW stats to user space")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>