Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

From: Mark Brown
Date: Thu Mar 21 2024 - 13:48:41 EST


On Thu, Mar 21, 2024 at 06:32:03PM +0100, Karel Balej wrote:
> Mark Brown, 2024-03-21T17:17:40+00:00:

> > Do they both genuinely have the same maximum register?

> They do according to the downstream driver which is my only reference.
> In fact, there the driver defines the configs separately for each regmap
> but with the same values.

This is a downstream driver - are you sure it's got the best code
quality? I'm not seeing any references to registers with numbers as
high as the maximum register that's there in your driver for example.

Attachment: signature.asc
Description: PGP signature