Re: [PATCH] rust: time: add Ktime

[Alice Ryhl]

On Wed, Mar 20, 2024 at 2:18 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> On Wed, Mar 20 2024 at 10:08, Alice Ryhl wrote:
> > +impl Ktime {
> > +    /// Create a `Ktime` from a raw `ktime_t`.
> > +    #[inline]
> > +    pub fn from_raw(inner: bindings::ktime_t) -> Self {
> > +        Self { inner }
> > +    }
> > +
> > +    /// Get the current time using `CLOCK_MONOTONIC`.
> > +    #[inline]
> > +    pub fn ktime_get() -> Self {
> > +        // SAFETY: It is always safe to call `ktime_get`.
>
> That's not entirely correct. ktime_get() cannot be safely invoked from
> NMI context. That won't matter for driver writers obviously.
>
> Looks sensible otherwise.

Thanks for pointing that out. I will send a v2 with a reworded comment soon.

Alice