Re: [PATCH 1/2] dt-bindings: usb: qcom,pmic-typec: drop port description

From: Bryan O'Donoghue
Date: Fri Mar 22 2024 - 08:35:49 EST


On 22/03/2024 11:52, Dmitry Baryshkov wrote:
The PMIC Type-C controller doesn't have separate role-switching signal.
Instead it has an HS signal connection between embedded USB-C connector
node and the HS port of the USB controller.

I take your point on port as a signal but the way type-c determines data-role is via the DR_Swap message.

https://www.embedded.com/usb-type-c-and-power-delivery-101-power-delivery-protocol/

We receive an IRQ which is a packet containing DR_Swap - TCPM consumes that data and does a data-role switch.

The port then establishes the link between typec-port and redriver or PHY.

So, I think HS should be dropped from the commit logs and names in both series.

BTW for the GLINK devices I think the adsp firmware just notifies the APSS of the data-role switch so, these types of devices probably should have an epdoint with "usb_role_switch" in the name.

---
bod