Re: [PATCH] [RESEND] irqchip: armada: suppress unused-function warning

[Andrew Lunn]

On Fri, Mar 22, 2024 at 01:58:25PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> armada_370_xp_msi_reenable_percpu is only defined when CONFIG_PCI_MSI
> is enabled, and only called when SMP is enabled.
> 
> Without CONFIG_SMP, there are no callers, so we get a build time
> warning instead:
> 
> drivers/irqchip/irq-armada-370-xp.c:319:13: error: 'armada_370_xp_msi_reenable_percpu' defined but not used [-Werror=unused-function]
>   319 | static void armada_370_xp_msi_reenable_percpu(void) {}
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Mark the function as __maybe_unused to avoid adding more complexity
> to the #ifdefs.
> 
> Fixes: 8ca61cde32c1 ("irqchip/armada-370-xp: Enable MSI affinity configuration")
> Link: https://lore.kernel.org/lkml/20221215170202.2441960-1-arnd@xxxxxxxxxx/
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew