Re: [PATCH] x86/shstk: Enable shadow stack for x32

From: Edgecombe, Rick P
Date: Fri Mar 22 2024 - 10:07:41 EST


On Fri, 2024-03-15 at 07:34 -0700, H.J. Lu wrote:
> > How many people do you think will use this?

I'm concerned that the only use of this will ever be exercise via the
glibc unit tests, but will still require work to support.

> >
> > I would have thought it would require more changes for basic x32
>
> This is all needed.
>
> > operation. What was the testing exactly?
>
> I configured x32 glibc with --enable-cet, build glibc and
> run all glibc tests with shadow stack enabled.  There are
> no regressions.  I verified that shadow stack is enabled
> via /proc/pid/status.

The shadow stack is supposed to be mapped above 4G, so how is this
supposed to work for x32?