Re: [PATCH net-next] net: phy: dp8382x: keep WOL setting across suspends

[Andrew Lunn]

> > It looks like the issue I'm trying to address in this patch is not
> > specific to dp8382x. Right now, depending on if the PHY is reset or not
> > during resume (either through mdio_device reset_gpio/reset_ctrl or
> > phy_driver soft_reset callback), the WOL configuration is either the PHY
> > reset value or the BIOS value. I could still make the patch but it
> > doesn't really make sense to address only dp8382x.

This is an interesting point. soft_reset the driver is in control
off. It can preserve the WoL setting over the soft reset.
A hardware reset is a different matter.

However, if we woke up due to WoL, the PHY never went to sleep, its
state is intact, so why are we doing a hardware reset?

      Andrew